Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forwarding close methods to several writer implementations #636

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Add forwarding close methods to several writer implementations #636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
939343b
Decode CBOR in the diode test to fix workflow failures
gmbuell Jan 13, 2024
a3175cd
Use CBOR decoding in the ctx test which is also failing the workflow
gmbuell Jan 13, 2024
b904cfc
Add forwarding close methods to several writer implementations
gmbuell Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Decode CBOR in the diode test to fix workflow failures
  • Loading branch information
@gmbuell
gmbuell committed Jan 13, 2024
commit 939343b64543e2467e1fadf40d8d43775f628d7d
2 changes: 1 addition & 1 deletion diode/diode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestFatal(t *testing.T) {
}

want := "{\"level\":\"fatal\",\"message\":\"test\"}\n"
got := string(slurp)
got := cbor.DecodeIfBinaryToString(slurp)
if got != want {
t.Errorf("Diode Fatal Test failed. got:%s, want:%s!", got, want)
}
Expand Down
Loading