This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
feat(http): add default values for --bits and --profile in ipfs init #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a expanded profiles length check that is more accurate
koivunej
reviewed
Apr 6, 2022
| @@ -95,7 +95,7 @@ fn main() { | |||
| std::process::exit(1); | |||
| } | |||
| Err(config::InitializationError::InvalidRsaKeyLength(bits)) => { | |||
| eprintln!("Error: --bits out of range [1024, 16384]: {}", bits); | |||
| eprintln!("Error: --bits out of range [2048, 16384]: {}", bits); | |||
There was a problem hiding this comment.
Good spotting! Unsure how this got left in, the 1024-bit rsa keys never worked with ring, which was an issue in the beginning as ipfs bootstrap nodes were using those.
|
Thanks for this @rand0m-cloud. In near-term it would be nice to get rid of the RSA keys. I think I saw there being some support for ipfs' or libp2p compatible ec key serialization in rust-libp2p as well, which would allow removal of lot of complications. bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default values for the
ipfs initcommand to be more like the go-ipfsipfs init.--bits 2048and--profile defaultare the default flags if they not overridden.I've also included an profiles length check that is more accurate and injects the default profile if none was provided. Plus a small update to an error print statement because 1024 bits for a RSA key is too low.