Add a test failure reason #500
Conversation
rand0m-cloud
changed the title
|
bors r+ |
500: Add a test failure reason r=koivunej a=rand0m-cloud I just spent some time debugging test failures as I looked back through previous versions of rust-ipfs. The test `pre_configured_listening_addrs` assumes that port 4001 is available for binding and hopes that the multiaddr `/ip4/127.0.0.1/tcp/4001` is found in `ipfs.identify()`. I always run an IPFS daemon in the background for web app development and found the test passing when I killed the daemon. This PR adds additional context to the error message, `is port 4001 available to listen on?`. Co-authored-by: Addy Bryant <[email protected]>
|
This seems straightforward one, thanks for this! As for this particular test, I think the port number could had been anything else, I guess except for 0. |
|
Oki the build is failing for some inference related change in the stable rust ... Argh. Nice thing I set the cron build to catch these, but apparently notifications are missing from the builds. I'll see more into this tomorrow. Might be that this is only fixed with upgraded deps. |
|
Build failed: |
|
Yeah, I was facing that and that's why I was working to update the dependency. Now that I think about it, it might have been easier to make a patch level upgrade to build on stable Rust. |
|
Yeah seems like everyone else should had been hitting this as well, did not check if there's a patch version for this. |
|
FWIW, I've made a v0.39.2 tag on my repo that fixes the build error in libp2p-noise. I can't seem to open a PR comparing it to v0.39.1 on libp2p. I'm not sure it would be worth my time to make a PR on libp2p and rust-ipfs when my other PR is almost ready. |
koivunej
force-pushed
the
add_context_to_test
branch
from
de0af15
to
3fcf7fa
Compare
|
bors r+ |
|
Build succeeded: |
I just spent some time debugging test failures as I looked back through previous versions of rust-ipfs. The test
pre_configured_listening_addrsassumes that port 4001 is available for binding and hopes that the multiaddr/ip4/127.0.0.1/tcp/4001is found inipfs.identify(). I always run an IPFS daemon in the background for web app development and found the test passing when I killed the daemon.This PR adds additional context to the error message,
is port 4001 available to listen on?.