This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 164
Update libp2p to v0.43.0 #499
Merged
+375
−186
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f601b8d
fix: update libp2p and renamed the changed types
rand0m-cloud c3a48c9
fix: updated libp2p in the bitswap crate
rand0m-cloud 4e5ff4d
more libp2p updating
rand0m-cloud 918d4d8
more updating of types
rand0m-cloud c1a5bba
some updates to pubsub
rand0m-cloud 7e9da72
fix the pubsub network behaviour action type
rand0m-cloud 085be77
replaced todo placeholders
rand0m-cloud e4002d6
re-add connection closed and established
rand0m-cloud a996922
added change to changelog
rand0m-cloud bdf977c
enable event_process for BehaviourEvent
rand0m-cloud 93b31b3
chore: clean up type signature
rand0m-cloud 25c8d58
fix: removed unneeded BehaviourEvent struct
rand0m-cloud 3b59193
temp fix: changed field order to workaround bug in libp2p
rand0m-cloud 31262b5
chore: more updating to libp2p
rand0m-cloud 6c6fc3d
fix: update libp2p and renamed the changed types
rand0m-cloud 77291ee
fix(swarm-test): add biased to tokio::select for non-random behavior
rand0m-cloud 888e6f1
wip: re-add code fragment to handle dial failure
rand0m-cloud 72ff95d
fix(swarm): corrected dial failure logic
rand0m-cloud 1cee67d
fix: corrected faulty Vec::retain logic and updated WrongPeerId test
rand0m-cloud 897c16f
fix: apply review suggestions and fix clippy lints
rand0m-cloud d4d3def
fix(pubsub): tell Floodsub about the peers we want to hear from
rand0m-cloud 87a4114
ci(win): use windows-2019 image
koivunej 82453e5
fix(build): stop building while writing an error
koivunej 277954b
test(pubsub): disjoint topics as new test case
koivunej 50ad10f
test(pubsub): simplify, comment
koivunej 081a598
test(conf): ignore pubsub tests on windows for now
koivunej bf7a807
doc(p2p): add fixme for possible issue
koivunej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
replaced todo placeholders
- Loading branch information
commit 085be771fe3061c1d732cddd444efcfb1766758c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this needs to be removed? I'm not sure how to adapt the behavior because
inject_dial_failure
only tells us when a connection failed to dial.I think this current block was made for attempting another connection when one fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right ... Looking at the networkbehaviour, I think this is how it used to work:
NetworkBehaviour::addresses_of_peer
, dials them somehowWhile writing this @mxinden replied. Oki yeah it would appear the failures have now moved within the dialerror, which I did not expect, AND there is only one "notification" for all of the attempts.
However I think the idea with the original impl was that since there would be one gathering of addresses for the peer (
NetworkBehaviour::addresses_of_peer
) per dial events (caused either by "swarm_api" or by any other place) it would be possible to add new addresses during a dial attempt, and those would be noticed at (4) in the above ordered list, and thus get dialed afterwards.I now realize that this all should had been in the swarm api implementation as comments, but I guess I was expecting the datastructures and network behaviour api to make this "apparent" and did not account for possible future changes in the network behaviour api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the next steps would be to gather the failed addresses from the error (if found), then continue dialing to the remaining addresses, if any.