This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
chore: upgrade to libp2p 0.39 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Aug 17, 2021
CHr15F0x
force-pushed
the
update_deps_2
branch
from
ba8fbff
to
87aaefd
Compare
Includes replacing `upgrade::{write_one, read_one}` with `upgrade::{write_length_prefixed, read_length_prefixed}` respectively, which is a direct consequence of [PR2111](libp2p/rust-libp2p#2111).
CHr15F0x
force-pushed
the
update_deps_2
branch
from
87aaefd
to
c7a7998
Compare
|
Cancelling the post-rebase run because bors will rerun it. bors r+ |
|
Build succeeded: |
|
Thank you @CHr15F0x for going through with this. We mostly had the "review" in chat but we mostly noted the |
bors bot
added a commit
that referenced
this pull request
Aug 23, 2021
473: Swarm cleanup following libp2p upgrade to v0.39.1 r=koivunej a=CHr15F0x This is a follow up of #472. There are two changes introduced: * remove eq_greedy as `Multiaddr` in `SwarmApi::pending_{addresses, connections}` contains p2p, align conversions accordingly (136496f), * explicitly use `MultiaddrWithPeerId` in `SwarmApi::pending_{addresses, connections}` (3b6f695). The former (136496f) works fine without the latter (3b6f695), however I am leaning more towards keeping both changes. Encoding the information about peer id presence/absence in Multiaddr in _type_ instead of relying on comments and `expect()`s improves readability and _developer experience_. Please let me know what your thoughts are. Co-authored-by: Krzysztof Lis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #463.
It includes the following:
Incoming shortly:
I haven't run the changes against current workflow, so some additional fixes could be necessary;edit: though I did check against all tests locally numerous times during dev, albeit only in a linux/x64 environment; btw looks like the workflows are fine with the changes