This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
ci: cache improvements #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these sound normal, but could be explained with something changing underneath in windows or just our tests lagging behind. |
koivunej
reviewed
Aug 16, 2021
koivunej
reviewed
Aug 16, 2021
.github/workflows/ci.yml
Outdated
| tar -xf go_ipfs.tar.gz | ||
|
|
||
| - name: Install dependencies windows (openssl) | ||
| - name: Install dependencies (windows) |
There was a problem hiding this comment.
There's still the nagging about "setupOnly" which ... I don't know why it would interfere with caching. https://github.com/rs-ipfs/rust-ipfs/pull/471/checks?check_run_id=3339830233#step:33:3
There was a problem hiding this comment.
Ok, this is luckily nicely documented, I just had missed it: https://github.com/marketplace/actions/run-vcpkg#setup-vcpkg-only-and-use-your-own-scripts
There was a problem hiding this comment.
Just enabled this option, will test if it caches on my fork.
--edit--
Appears to have worked, 6minute step down-to 20secs.
There was a problem hiding this comment.
This still requires the openssl installing step, at least per the docs.
Mirko-von-Leipzig
force-pushed
the
ci/cache
branch
from
d2b2edc
to
e7c22a5
Compare
This allows for manually triggering the workflow. Particularly useful for running CI on forks without creating a PR.
New name is simply the host OS. Previously was a long string including all parameters, which wouldn't fit on the GH page.
This replaces the existing one, which wasn't caching much.
This was used to debug a crash which no longer occurs. Removing lets us simplify the workflow file, and improves caching.
The setup for the conformance test would always build the npm packages. Instead we now check for a cache hit, and only build if we miss.
Groups steps together where sensible, and made the naming more uniform.
Mirko-von-Leipzig
force-pushed
the
ci/cache
branch
from
e7c22a5
to
a4e2384
Compare
|
Excellent, looking great. bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 16, 2021
471: ci: cache improvements r=koivunej a=Mirko-von-Leipzig This PR improves the CI caching, roughly halving the time required when caches are hit (no dependency or toolchain changes). Overview of changes: - Use [rust-cache action](https://github.com/Swatinem/rust-cache). This forms the bulk of the time improvement as Rust dependencies are now cached. - Improve npm caching for conformance tests. This trims 2-3 minutes of build time. - Improve job and step naming. - Add a manual trigger for the workflow. - Remove core dump for macos, no longer required. Further details can be found in the commits. I've been running into sporadic conformance test failures on windows ([link to run](https://github.com/Mirko-von-Leipzig/rust-ipfs/actions/runs/1135372291)): ``` 1) .pubsub.subscribe multiple connected nodes should send/receive 100 messages: FetchError: request to http:https://127.0.0.1:50533/api/v0/pubsub/pub?arg=pubsub-tests-C-aIrZS_7OSQMNSVOMszV failed, reason: read ECONNRESET at ClientRequest.<anonymous> (node_modules\node-fetch\lib\index.js:1455:11) at Socket.socketErrorListener (_http_client.js:475:9) at emitErrorNT (internal/streams/destroy.js:106:8) at emitErrorCloseNT (internal/streams/destroy.js:74:3) at processTicksAndRejections (internal/process/task_queues.js:82:21) ``` Co-authored-by: Mirko von Leipzig <[email protected]>
|
Build failed: |
Mirko-von-Leipzig
force-pushed
the
ci/cache
branch
4 times, most recently
from
9b7130a
to
ecdd14d
Compare
Mirko-von-Leipzig
force-pushed
the
ci/cache
branch
from
ecdd14d
to
df11329
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CI caching, roughly halving the time required when caches are hit (no dependency or toolchain changes).
Overview of changes:
Further details can be found in the commits.
I've been running into sporadic conformance test failures on windows (link to run):