This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Fix (windows) build #469
Merged
Fix (windows) build #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6223d92
to
b09b478
Compare
if you want to contest this change, please do go ahead and let us know you'd benefit from having these enabled. originally they were added because adding multiple images to build worked most of the time without any downside with unlimited free CI.
hopefully it would have better diagnostic.
|
Awaiting to populate the caches (hopefully). |
|
Maybe it was a transient failure? bors r+ |
|
Build succeeded: |
This was referenced Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old vcpkg commit
ffa41582f78478812c836a6e8ce315fb27431182has started segfaulting for some unknown reason. This PR:261c458af6e3eed5d099144aff95d2b5035f656b(2) is to save CI seconds until we know better; when this was decided previously CI seconds were practically unlimited; we'll need another decision on that. I don't think anyone is using the android build for example yet.
(3) will follow up with another PR to handle these.