This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Fix multinode test spans #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differences (old => new): - "ipfs:swarm" => "ipfs::exec" - "ipfs[:bg_task]" => "ipfs::swarm" The previous commit already changed introduced and separated "ipfs" and "ipfs:facade".
koivunej
force-pushed
the
fix_multinode_test_spans
branch
from
a6e319b
to
e01b03a
Compare
|
The windows failure looks transient. Merging this tomorrow-ish unless there are objections. Better ways we should be using |
|
This is essential to understand anything of the logs in the following PRs so merging this in. bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the spans are set up from IpfsOptions and in UninitializedIpfs. While debugging the now ignored test (see #450) I found that the spans were configured wrong and thus none of the multiple nodes created by
spawn_nodescould be differentiated.This also renames the spans to more logical from the "$root" given at
IpfsOptions::span:Span::current=>$root:initSpan::current=>$root:init:swarm$root:swarm=>$root:exec(literally the executor libp2p spawns futures through)$root=>$root:bg_task=>$root:swarm(background task)$root=>$root:facade(futures created through Ipfs::* methods)Still very far from perfect, but perhaps a step into better direction.