This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
feat: repo locking with fs2 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of repo locking caused tests with multiple nodes using the same temporary repo directory to fail.
niklaslong
force-pushed
the
402-repolocking
branch
from
e61c36a
to
e60e983
Compare
koivunej
reviewed
Nov 12, 2020
This was after concerns were raised about potential time-of-check to time-of-use (TOCTOU) issues. The check isn't actually necessary as `OpenOptions::create` set to `true` will create only if the file doesn't already exist.
niklaslong
force-pushed
the
402-repolocking
branch
from
fa7e982
to
02d98ad
Compare
koivunej
reviewed
Nov 13, 2020
There was a problem hiding this comment.
Minor nit on the perhaps extra #[async_trait]. Bigger issue with the unwraps. Great that this started working.
As we've already discussed, the fs2 dependency while not actively maintained is probably ok for the short/medium-term. I can't see many reasons why this functionality would have to change though, given the fact that libc stuff doesn't change to often.
Repo locking was previously performed on repo::new, this keeps the Lock struct initialisation in repo::new but moves the locking into repo::init.
niklaslong
force-pushed
the
402-repolocking
branch
from
9e74bb1
to
500e401
Compare
koivunej
approved these changes
Nov 17, 2020
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #426 and resolves #243.
This implements repo locking with fs2. The only concern for this crate is that it is poorly maintained but the functionality we need seems stable enough for now.
Certain tests are currently failing, notably because multiple nodes are being created with the same repo (dag tests for instance). Not sure what the solution to this will be...
Update: running tests with
--test-threads=1passes all unit tests. The integration tests fail (I think because multiple nodes are being spun up with the same repo).Update 2: all green, making sure test nodes use a different temp dir for the repo fixed the tests.