This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
feat(http): create Profile abstraction to allow port choice #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
changed the title
koivunej
reviewed
Oct 23, 2020
niklaslong
changed the title
koivunej
reviewed
Oct 27, 2020
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Oct 30, 2020
423: http: configuration refactor r=niklaslong a=niklaslong This is a wip but opening as a draft to keep track of this follow up to #421. This is also part of #402. This introduces the `Config` struct to serve as a facade to the configuration module. It's essentially a flattened `CompatibleConfigFile` struct exposing only the fields necessary to running the daemon. Co-authored-by: Niklas Long <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
Profileabstraction to allow the customisation of port selection as discussed in #402.Two profiles are supported:
Testfor use with conformance tests (ephemeral port selection)Defaultserves on4004