This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Prepare unixfs release v0.1.0 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 14, 2020 15:47
tried to look into how should the links be done today but I guess there are still some nightly shenanigans so cannot really preview before publishing.
|
I find it really odd that broken inter-crate links in docs are not compile errors. I think we should just publish a new version and then see how docs.rs renders them? Those are probably good enough already. |
ljedrz
reviewed
Aug 14, 2020
ljedrz
reviewed
Aug 14, 2020
ljedrz
reviewed
Aug 14, 2020
Co-authored-by: ljedrz <[email protected]>
bors bot
added a commit
that referenced
this pull request
Aug 14, 2020
313: Prepare unixfs release v0.1.0 r=ljedrz a=koivunej Per semver the next must be a minor bump at least. While I don't have a concrete path forward to 1.0 in mind for this crate I am sure we'll be doing smaller bits and bobs soon as we approach a rust-ipfs release as well. Co-authored-by: Joonas Koivunen <[email protected]> Co-authored-by: Joonas Koivunen <[email protected]>
|
Build failed: |
|
Good job me :D |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per semver the next must be a minor bump at least. While I don't have a concrete path forward to 1.0 in mind for this crate I am sure we'll be doing smaller bits and bobs soon as we approach a rust-ipfs release as well.