Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

calling Ipfs::restore_bootstrappers doesn't end up connecting to any bootstrapper #405

Closed
koivunej opened this issue Oct 6, 2020 · 0 comments · Fixed by #406
Closed

calling Ipfs::restore_bootstrappers doesn't end up connecting to any bootstrapper #405

koivunej opened this issue Oct 6, 2020 · 0 comments · Fixed by #406
Assignees
@koivunej
Labels
bug Something isn't working

Comments

@koivunej
Copy link
Collaborator

koivunej commented Oct 6, 2020

Describe the bug

Ipfs::restore_bootstrappers doesn't end up connecting to any bootstrapper.

To Reproduce
Steps to reproduce the behavior:

  1. Create new empty inmemory backed node with generated keys
  2. After spawning the IpfsFuture, call and await on ipfs.restore_bootstrappers
  3. Find popular content, like /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme or bafkreicncneocapbypwwe3gl47bzvr3pkpxmmobzn7zr2iaz67df4kjeiq (in the dht_popular_content_discovery)
  4. Find no content, logs show:
2020-10-06T07:35:17.463411Z DEBUG ipfs: ipfs::subscription: Creating subscription 0 to Obtain block QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc
2020-10-06T07:35:17.465173Z TRACE libp2p_kad::behaviour: Query QueryId(0) finished.

Expected behavior

Connection(s) are made to the restored bootstrappers and dht query doesn't finish instantly.

Screenshots

This is a library.

Desktop (please complete the following information):

Probably better to ask about uname -ar or similar?

Additional context

This could probably be removed, as the screenshots, and the hints about scrolling a GUI application or something, also the bug is a label but also (redundantly) [BUG] on the subject line.
@koivunej koivunej added the bug Something isn't working label Oct 6, 2020
@koivunej koivunej self-assigned this Oct 6, 2020
koivunej pushed a commit to eqlabs/rust-ipfs that referenced this issue Oct 6, 2020
fix: add peers when restoring bootstrappers
f6e1d83 
fixes rs-ipfs#405 while also changing the return value to be the restored
values (at the moment 0 or 1 multiaddrs).
@koivunej koivunej mentioned this issue Oct 6, 2020
Merged
koivunej pushed a commit to eqlabs/rust-ipfs that referenced this issue Oct 6, 2020
fix: add peers when restoring bootstrappers
9795b30 
fixes rs-ipfs#405 while also changing the return value to be the restored
values (at the moment 0 or 1 multiaddrs).
@koivunej koivunej changed the title [BUG] calling Ipfs::restore_bootstrappers doesn't end up connecting to any bootstrapper calling Ipfs::restore_bootstrappers doesn't end up connecting to any bootstrapper Oct 6, 2020
bors bot added a commit that referenced this issue Oct 7, 2020
@bors @koivunej
Merge #406
bac542a 
406: fix restore_bootstrappers doesn't enable content discovery r=koivunej a=koivunej

Fixes #405 and also:

- makes sure ipfs.restore_bootstrappers is used in the `dht_popular_content_discovery` test
- adds a test case making sure we can parse all config::BOOTSTRAP_NODES
- ~adds some FIXMEs we couldn't decide yet on the other /bootstrap impl~ handled
- expose ipfs::config to allow http to access ipfs::config::BOOTSTRAP_NODES to enable the http api semantics
- keep exposing the delta semantics in ipfs.restore_bootstrappers
- use ipfs.restore_bootstrappers in examples/fetch_and_cat.rs via new `--default-bootstrappers` option/mode
- add tracing to *_bootstrapper methods

Co-authored-by: Joonas Koivunen <[email protected]>
Co-authored-by: Joonas Koivunen <[email protected]>
@bors bors bot closed this as completed in ce832d9 Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@koivunej koivunej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix restore_bootstrappers doesn't enable content discovery eqlabs/rust-ipfs
1 participant
@koivunej