Skip to content

Commit

Permalink
Explicitly provide type parameters. (#805)
Browse files Browse the repository at this point in the history
This is an info diagnostic that will soon become a warning.
  • Loading branch information
eyebrowsoffire committed Feb 19, 2023
1 parent ade6982 commit ec73120
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions lib/src/devtool.dart
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ class ProviderNode {
required this.id,
required this.childrenNodeIds,
required this.type,
required _InheritedProviderScopeElement element,
required _InheritedProviderScopeElement<Object?> element,
}) : _element = element;

final String id;
final String type;
final List<String> childrenNodeIds;
final _InheritedProviderScopeElement _element;
final _InheritedProviderScopeElement<Object?> _element;

Object? get value => _element._delegateState.value;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/src/listenable_provider.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class ListenableProvider<T extends Listenable?> extends InheritedProvider<T> {
);

static VoidCallback _startListening(
InheritedContext e,
InheritedContext<Listenable?> e,
Listenable? value,
) {
value?.addListener(e.markNeedsNotifyDependents);
Expand Down
4 changes: 2 additions & 2 deletions test/null_safe/common.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Type typeOf<T>() => T;
///
/// For use in legacy tests: they can't instantiate a `Provider<T?>` directly
/// because they can't write `<T?>`. But, they can pass around a `Provider<T?`>.
Provider<T?> nullableProviderOfValue<T>(T value, Provider? child) =>
Provider<T?> nullableProviderOfValue<T>(T value, Provider<dynamic>? child) =>
Provider<T?>.value(
value: value,
child: child,
Expand All @@ -35,7 +35,7 @@ Provider<T?> nullableProviderOfValue<T>(T value, Provider? child) =>
/// Given `T`, returns a `Provider<T>`.
///
/// For legacy tests to get a `Provider<T>`.
Provider<T> nullSafeProviderOfValue<T>(T value, Provider? child) =>
Provider<T> nullSafeProviderOfValue<T>(T value, Provider<dynamic>? child) =>
Provider<T>.value(
value: value,
child: child,
Expand Down

0 comments on commit ec73120

Please sign in to comment.