Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dynamic TargetDescription #3780

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added dynamic TargetDescription #3780

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c276f0e
Added dynamic `TargetDescription`
theIDinside Jul 11, 2024
56cc86c
Actually provide aarch64-fpu.xml to gdb
theIDinside Jul 11, 2024
b194918
Fix formatting issues
theIDinside Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually provide aarch64-fpu.xml to gdb 
I don't even know how we have sent this before or why this hasn't been a bug prior to this.
  • Loading branch information
@theIDinside
theIDinside committed Jul 11, 2024
commit 56cc86cc63e2997c840b6bd09c679122d98b1248
4 changes: 4 additions & 0 deletions src/TargetDescription.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ FeatureStream& operator<<(FeatureStream& stream,
case TargetFeature::Segment:
stream << "seg.xml";
break;
case TargetFeature::FPU:
stream << "fpu.xml";
break;
}
stream << R"("/>)" << '\n';
return stream;
Expand All @@ -92,6 +95,7 @@ TargetDescription::TargetDescription(rr::SupportedArch arch,
break;
case rr::aarch64:
target_features.push_back(TargetFeature::Core);
target_features.push_back(TargetFeature::FPU);
break;
}

Expand Down
3 changes: 2 additions & 1 deletion src/TargetDescription.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ enum class TargetFeature : u32 {
Linux,
Segment,
AVX,
PKeys
PKeys,
FPU,
};

class TargetDescription {
Expand Down