Fix seek-ticks when already at the target event #3522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this,
seek-ticks
would go to an incorrect tick if the current event and target tick event are the same, easiest reproducible by runningseek-ticks
with the same argument twice (where there isn't an event on exactly that tick).This patch passes manual testing seeking back, forward, over events or not, and on tick numbers immediately before/after an event.