CI: add an async timer to kill ctest before the Buildkite job times out
#3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
ctest before the Buildkite job times outctest before the Buildkite job times out
|
@Keno I think this is good to go. |
Keno
reviewed
Mar 28, 2022
.buildkite/pipeline.yml
Outdated
| @@ -3,8 +3,8 @@ agents: | |||
| sandbox.jl: "true" | |||
| os: "linux" | |||
| steps: | |||
| - label: "x86_64" | |||
| key: "x86_64" | |||
| - label: "Test" | |||
There was a problem hiding this comment.
I've changed it to Run Tests (x86_64), which I think is more descriptive than just listing the architecture.
Keno
reviewed
Mar 28, 2022
| @@ -118,7 +144,7 @@ mktempdir(my_temp_parent_dir) do dir | |||
| end | |||
|
|
|||
| buildkite_upload_cmd = `buildkite-agent artifact upload $(dst_file_name)` | |||
| if is_buildkite && !success(proc) | |||
| if !success(proc) | |||
There was a problem hiding this comment.
@DilumAluthge Any reason this condition got removed?
There was a problem hiding this comment.
Yeah, so I was thinking that it seems unlikely that anyone would ever run the capture_tmpdir.jl script outside of CI, so I removed the "check if this is Buildkite" logic for simplicity.
That being said, if we anticipate that people might want to run this script locally, we should add that logic back.
There was a problem hiding this comment.
No, that's fine. Just wanted to check that it was intentional.
Keno
reviewed
Mar 28, 2022
.buildkite/pipeline.yml
Outdated
| @@ -3,8 +3,8 @@ agents: | |||
| sandbox.jl: "true" | |||
| os: "linux" | |||
| steps: | |||
| - label: "Test" | |||
| key: "Test" | |||
| - label: "Run Tests (x86_64)" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
14, it immediately throws an error and exits. (And nothing is uploaded.)17, itSIGTERMs thectestprocess, and theTMPDIRis uploaded as a build artifact.45and make sure that CI is green.