Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move the CTestCostData.txt file into place before running the tests #3050

Merged
merged 1 commit into from
Jan 20, 2022
Merged

CI: Move the CTestCostData.txt file into place before running the tests #3050

merged 1 commit into from
Jan 20, 2022

Conversation

DilumAluthge
Copy link
Contributor

This uses the CTestCostData.txt file from Keno's comment here: #3046 (comment)

@Keno
Copy link
Member

Keno commented Jan 20, 2022

I think this is working. It's starting with the long-running tests. We may see less benefit while we still have failing tests, since some of them are timeouts, which makes the cost values inaccurate.

@DilumAluthge
Copy link
Contributor Author

Yeah, once we have fixed some of the failing tests, it will probably be worth updating the cost file.

@Keno
Copy link
Member

Keno commented Jan 20, 2022

I think this is working, but my local test file worked less well than I expected vsyscall_reverse_next-no-syscallbuf takes no time locally, but almost 300s on CI (and got scheduled right at the end). Not sure what the difference is. But regardless, let's merge this, fix all the tests and then generate a cost file on CI that matches that environment.

@Keno Keno merged commit a14a8a9 into rr-debugger:master Jan 20, 2022
@DilumAluthge DilumAluthge deleted the dpa/ctest-cost-data branch January 20, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants