Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for rqworker settings files #85

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

prehensile
Copy link

as detailed at https://python-rq.org/docs/workers/

Allows rq-scheduler to read from these config files, thus enabling sharing of config with rqworker.

@selwin
Copy link
Contributor

selwin commented Jul 29, 2015

Hi @prehensile , I think this is a great idea. Do you mind if we reuse RQ's implementation for much of the configuration parsing though? I'd rather keep the two scripts as similar as possible for consistency and to lower maintenance burden.

For example, we can delegate connection setup to rq.cli.cli.connect, the cli script also has many decorators that we can reuse to simplify argument parsing such as url_option and config_option.

Ideally, we should also convert the script to use click - this means we should also require a recent version of RQ in setup.py

@prehensile
Copy link
Author

@selwin good points, I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants