[pull] master from MCUdude:master #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
And not just the ones with 256 bytes pash pages. Thanks for the help @technoblogy\!
Apparently, this is used to determine if a target has more than one i2c port, which the 324PB has
Add missing missing delete operators introduced in C++14 Merge commit 'b4021a38eca08817dee1684814bbd426721d11a4'
…4f48 278334f48 Merge pull request #33 from DrItanium/cpp17_support 7aaa2705b Add the extra delete operators introduced in C++14 git-subtree-dir: avr/cores/MCUdude_corefiles git-subtree-split: 278334f48f2d7049b323cd5fe3864727d8228475
Enable gnu++17 support by default
MCUdude
force-pushed
the
master
branch
2 times, most recently
from
e61c284
to
f669a1a
Compare
Adding ATmega32U4 Arduino as ISP programmer
This platform uses a build hook to save a disassembler listing to the build folder when compiling sketches. Due to the use of a redirection operator in the command, it was necessary to execute it via the Windows command interpreter by passing it as an argument to `cmd /c`. Although paths with spaces can be used without difficulty in pattern generated commands executed directly by the Arduino framework, things are more complicated when it comes to executing commands indirectly via `cmd /c`. The `cmd /c` command has an odd handling of quotes: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/cmd#remarks Under certain conditions, the first and last quotation mark of the command passed via the argument to `/c` are stripped. These conditions occur for the command generated via the platform's `recipe.hooks.objcopy.postobjcopy.1.pattern.windows` property when the both the path to `avr-objdump` and the temporary build path contain a space. The removal of the essential quotes from the start and end of the command executed by `cmd /c` causes an error. for example, if the `avr-objdump` path was: ``` C:\Users\username with spaces\AppData\Local\\Arduino15\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7\bin\avr-objdump ``` The command will fail with the error: 'C:\Users\username' is not recognized as an internal or external command, operable program or batch file. One of the required conditions for the unwanted quote stripping is that the first character of the argument to `cmd /c` is a double quote. So this unwanted behavior can be avoided by ensuring the first character is not a double quote. That is accomplished here by adding a dummy command that does not require quoting at the start of the argument. It might seem that a less hacky approach would be to simply wrap the entire argument to `cmd /c` in an extra layer of sacrificial quotes, leaving the essential quotes intact in the command that is finally executed. While that does indeed work when running the command directly from the command line, it does not work when used in a pattern in the Arduino platform configuration framework. The problem is that the string generated from the platform pattern can not be executed as is. It must be split into arguments. The list of arguments space separated, with quoting where an argument contains a space. These arguments may contain quote characters, which must be escaped. This escaping is where the simple approach of extra quotes becomes unusable. The `os/exec` Go package used to handle the escaping does that in a way that is compatible with directly executing a command, but is not compatible with the legacy escaping system used by cmd. It seems this problem of the command having paths with spaces did not occur in Arduino IDE 1.x due to it using a Windows "8.3" format instead. Arduino CLI (and thus Arduino IDE 2.x) use the full path format instead. It seems this problem of the command having paths with spaces did not occur in Arduino IDE 1.x due to it using a Windows "8.3" format for the default build path, which meant the path in the command did not contain spaces. Arduino CLI (and thus Arduino IDE 2.x) uses the full path format instead. However, the bug could also occur in Arduino IDE 1.x if the user sets a custom build.path with spaces. `recipe.hooks.savehex.presavehex.2.pattern.windows` also uses `cmd /C`. However, this command is not subject to the quote stripping because it does not ever have a double quote as the first character of the argument.
Prevent corruption of disassembler listing command for paths w/ spaces
Enable Wire timeout py adding -DWIRE_TIMEOUT as a compiler flag, or by incommening a line in Wire_timeout.h
This reverts commit ba21a9c.
it's time, don't you think?
Can be utilized by using the EEMEM attribute in the user program
Small grammar changes
|
Important Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )