Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #95 #96

Merged
merged 3 commits into from Aug 23, 2019
Merged

Fix #95 #96

merged 3 commits into from Aug 23, 2019

Conversation

dnagl
Copy link
Contributor

@dnagl dnagl commented Aug 17, 2019

This commit should fix issue #95

@dmnks
Copy link
Contributor

dmnks commented Aug 22, 2019

Hi David,
Are you sure this was the culprit? Doesn't /path/{A,B,C} expand to /path/A, /path/B and /path/C anyway?

@dnagl
Copy link
Contributor Author

dnagl commented Aug 22, 2019

I know, I tried the command manually on the commandline and there this worked fine.
I tried this on several machines with different OS and different environments. But I was not able to build this. The command always creaed this folder build/SOURCES,SRPMS,RPMS and so the following steps which are trying to work in the generated directories do not work.

@dmnks
Copy link
Contributor

dmnks commented Aug 22, 2019

OK, it seems brace expansions are not POSIX-compliant (although bash and most other shells do support them).

I'm fine with the patch then. Before I merge it, though, please also do the same correction under the clean: target where we do rm -f $(BUILDDIR)/{SOURCE,SRPMS,RPMS}/*.

@dnagl
Copy link
Contributor Author

dnagl commented Aug 22, 2019

@dmnks I added the changes in the clean: target.

Makefile Outdated Show resolved Hide resolved
@dmnks dmnks merged commit 098cf29 into rpm-software-management:master Aug 23, 2019
@dmnks
Copy link
Contributor

dmnks commented Aug 23, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants