Add podman-based development support #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
force-pushed
the
add-podman-support
branch
from
d875558
to
8abe6c8
Compare
|
@james-antill Hey, I don't feel like merging this without having involved another pair of eyes, so I'd like to ask you for a quick glance before I do. Note that this is just an upstream change that's not intended for Fedora or RHEL. Thanks! |
dmnks
force-pushed
the
add-podman-support
branch
5 times, most recently
from
74c6908
to
bdac7ba
Compare
This brings back old pygpgme support (when python2-gpg is not available) removed by commit 2996c09, allowing the upstream version of yum to work on CentOS/RHEL <= 7 again.
Source1 was never defined in the upstream spec file (so building an RPM would fail). In Fedora, we use it to override the upstream yum.conf with our own. As upstream should rather be distro-agnostic, let's just stick with the defaults here.
dmnks
force-pushed
the
add-podman-support
branch
2 times, most recently
from
376347d
to
9ac368c
Compare
Mostly useful for development.
This allows for running the binary from the source tree (with PYTHONPATH set to the tree). Previously, the binary would try to import itself when it calls "import yum" instead of the top-level package "yum" (the script directory is inserted _before_ PYTHONPATH in sys.path).
dmnks
force-pushed
the
add-podman-support
branch
from
9ac368c
to
25d28e4
Compare
After the newly migrated webserver VM, the original links for the PLUGINS and FAQ files no longer work, making "make rpm" fail. Let's replace these with empty files (the upstream spec file is not used for official releases anyway).
dmnks
force-pushed
the
add-podman-support
branch
3 times, most recently
from
c5d0987
to
4507edf
Compare
Conan-Kudo
approved these changes
Feb 13, 2019
dmnks
force-pushed
the
add-podman-support
branch
from
4507edf
to
439e4c2
Compare
|
I suppose it won't do any harm to have this merged, so I'll just do that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves a developer's (my) life :)