Don't pollute stderr in FIPS mode. BZ 1287610 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the system is in FIPS mode, certain unsecure checksum algorithms such as md5 are disabled by hashlib and thus not available in yum. We normally print an error during misc.py initialization for every such algorithm, however that's just too annoying if it happens on every yum run and is also confusing (as it doesn't say why the particular algorithm is disabled). Let's stop printing the message if the cause is FIPS mode and also extend the message that is printed when yum actually tries to use such a checksum algorithm (e.g. during repodata verification of a repo using md5) so that it says it's due to FIPS. Note: Custom FIPSNonCompliantError(MiscError) class is used instead of just MiscError so that we can make the resulting message shorter in YumRepository._checksum() without changing the message for any other exceptions handled in that method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system is in FIPS mode, certain unsecure checksum algorithms
such as md5 are disabled by hashlib and thus not available in yum. We
normally print an error during misc.py initialization for every such
algorithm, however that's just too annoying if it happens on every yum
run and is also confusing (as it doesn't say why the particular
algorithm is disabled).
Let's stop printing the message if the cause is FIPS mode and also
extend the message that is printed when yum actually tries to use such a
checksum algorithm (e.g. during repodata verification of a repo using
md5) so that it says it's due to FIPS.
Note: Custom FIPSNonCompliantError(MiscError) class is used instead of
just MiscError so that we can make the resulting message shorter in
YumRepository._checksum() without changing the message for any other
exceptions handled in that method.