Fix local package location xml href

[dekimsey]

Package remote location is mangled if it's name contains the same as the root directory path. We noticed this when a new package 'reporting-service' was added to our createrepo pipeline and the location href= became mangled.

What currently happens:

$ mkdir -p /repo/rpms
$ cp ~/reporting-service-0.1.3-1.el7.noarch.rpm /repo/rpms
$ createrepo --pretty --simple-md-filenames /repo
$ zgrep location /repo/repodata/primary.xml.gz
  <location href="rpmsrting-service-0.1.3-1.el7.noarch.rpm"/>

After patch:

...
$ zgrep location /repo/repodata/primary.xml.gz
  <location href="rpms/reporting-service-0.1.3-1.el7.noarch.rpm"/>

[james-antill]

In theory we should probably do something clever/obvious like:

https://stackoverflow.com/questions/16891340/remove-a-prefix-from-a-string

...but this is obviously fine, and is a two character change.

[dekimsey]

Just for completion's sake, if anyone runs into this bug there is a trivial work-around. Add a trailing slash to the createrepo command's directory argument.

# broken
createrepo --pretty --simple-md-filenames /repo
# works
createrepo --pretty --simple-md-filenames /repo/

Also, this issue was found on CentOS 7.

• yum-3.4.3-163.el7.centos.noarch
• createrepo-0.9.9-28.el7.noarch