Drop architecture from %builddir path #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatilai
force-pushed
the
builddir-name
branch
2 times, most recently
from
658bc4f
to
885c1f5
Compare
This causes more issues than it solves, at least presently. For one,
when BuildArch is used it typically causes the path to disagree with the
actual arch (eg on noarch packages). Which looks weird and causes yet
other issues in turn. The other issue, raised by Neal Gompa, is that
it can cause superfluous path differences in noarch subpackages, which
sharing the noarch package across multiple architectures in at least
koji.
Use -build suffix instead of %{_arch}. -build may seem redundant since
by default it's in BUILD directory already, but this makes it more
obvious in cases where the default is overridden (eg fedpkg overrides to
current directory), and helps differentiating it from the %buildsubdir
directory commonly created by %setup.
Suggested-by: Neal Gompa <[email protected]>
|
Oh hey, thanks for that! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes more issues than it solves, at least presently. For one, when BuildArch is used it typically causes the path to disagree with the actual arch (eg on noarch packages). Which looks weird and causes yet other issues in turn. The other issue, raised by Neal Gompa, is that it can cause superfluous path differences in noarch subpackages, which sharing the noarch package across multiple architectures in at least koji.
Use -build suffix instead of %{_arch}. -build may seem redundant since by default it's in BUILD directory already, but this makes it more obvious in cases where the default is overridden (eg fedpkg overrides to current directory), and helps differentiating it from the %buildsubdir directory commonly created by %setup.
Suggested-by: Neal Gompa [email protected]