Code cleanups in tests/rpmpgppubkeyfingerprint.c #3068
Conversation
tests/rpmpgppubkeyfingerprint.c
Outdated
| return 1; | ||
| } | ||
|
|
||
| // We expect success now. | ||
| char *got = rpmhex(fp, fplen); | ||
| if (! got) { | ||
| fprintf(stderr, "%s: rpmhex failed\n", filename); | ||
| fclose(f); |
There was a problem hiding this comment.
This should probably also free(fp);
Signed-off-by: Shreenidhi Shedi <[email protected]>
sshedi
changed the title
|
@ffesti I took the liberty to make this whole source look better. Please let me know if you want me to make changes in incremental commits. This is a small test file which is essentially testing a dummy function, so I made all changes in one commit. |
Better is subjective. The indentation was mostly following rpm coding style, now it's not. See Coding style / Indentation in CONTRIBUTING.md. Never, ever make formatting changes at the same time as other changes, and in particular, don't break what wasn't broken. It's impossible to review a change like this. In the light of recent events, "small test stuff" certainly needs reviewing too. One thing that did catch my eye despite that is pointless NULL checks before freeing. Don't do that, free() will do it for you anyhow. In the meanwhile, there are real cleanups/simplifications to be made. Like manually calculating string sizes when it could use rasprintf(), and manual getcwd() when we have rpmGetCwd() and malloc() with OOM checking for what's a static buffer that wouldn't need freeing. |
|
Accidentally closed it, I will open a new PR. |
|
Created #3072 |
No description provided.