cmake: move os-release parsing into oci branch #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but Michal is more familiar with the CI stuff. |
|
The Otherwise, looks good, thanks for the patch! |
os-release parsing is only needed for OCI usage, so move it inside the appropriate branch. Saves some operations at build time when not needed, and also it is necessary as not all OSes define VERSION_ID (e.g.: Debian Unstable and Archlinux)
|
(As a cosmetic touch up, I've also switched up the lines with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os-release parsing is only needed for OCI usage, so move it inside the appropriate branch. Saves some operations at build time when not needed, and also it is necessary as not all OSes define VERSION_ID (e.g.: Debian Unstable and Archlinux), so doing the parsing in the main block breaks the build. By moving it inside the OCI block, it runs only when needed.