Switch most of rpm over to C++ #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following commits will add the necessary C-style casts that make the codebase buildable both as C and C++. Intentionally exempt from this conversion are: - Python bindings (there's no big benefit to doing so, and will serve as a C API compatibility canary for now) - plugins (some plugins may want to move outside rpm now that the plugin API is public, give them time to do so) - low-level ndb engine (leaving to maintainer discretion) Switch to CMAKE_C_FLAGS and CMAKE_CXX_FLAGS for passing the various global compiler options as not all options are legitimate for both languages. Signed comparison warnings are disabled initially, those need to be cleared up eventually but for now, these issues exist in the C code already and it's known to work nevertheless. Similarly C++20 compatibility warnings are disabled initially (there are keyword clashes on "requires"), we'll cross that bridge when we come to it. Exceptions are disabled at least initially because at in this first stage this is effectively just C that doesn't know how to handle them, called by (mostly) other C that doesn't know either.
In other words, a whole lot of "yes, really".
The low level ndb engine is intentionally exempt here, leaving if/when to maintainer discretion.
|
This is (very) obviously a case of "things will get worse before they get better", these casts are just unsightly but most will go away once things are converted to actual native C++. We'll rename the C++ sources to an appropriate extension before 6.0 (probably after 4.20 rc is out) but the cxx_sources hack is kinda necessary to get this thing bootstrapped, and also not having to rename things just now helps cherry-picking stuff to 4.20. |
|
🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2983, here goes.
More details in commits, but to summarize: add necessary casts to most of the codebase to make it buildable with a c++ compiler, and then switch over to c++. Exempt from this conversion are