Another batch of c++ preparation trivia #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C lets us do this but in C++ needs to run destructors at end of scope, so they better be properly initialized... These are all over the place but so trivial putting them to different commits doesn't make much sense.
The internal db interface expects rpmRC returns, C doesn't mind but C++ does so update those parts to pull the real rpmRC enum, update return code variable types to match.
Upstream Lua headers lack C++ guards, argh. Lump them all into rpmlua.h and deal with it centrally there. In the past we've avoided including Lua there but now that Lua is mandatory it doesn't cause other issues.
rpmlogCallbackData is already a pointer type, we don't want a pointer to a pointer for this. Kinda surprising it actually worked, but then it's just a void pointer so...
Should've been in commit 38b2602
rpmTagType can include information about the return type besides just the tag, so a strict enum wont do.
Static variables are initialized by the compiler, simply dropping this allows us to avoid the int/enum mismatch from initializing hash algo to an invalid 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.