Type pedantry and similar cleanups in preparation for c++ #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ doesn't like this...
In particular, spec->nextline is written to, so pointing it to a string literal is undefined behavior. NULL seems to achieve the same.
rpmTag doesn't include anything suitable for a sentinel value, so don't use it in array initializers. rpmTagVal works for that, but it's an unsigned type so use 0 instead of -1.
rpmTagVal is unsigned so we can't really have these -1's in there. Tag works for this purpose just as well - assuming I spotted all the explicit comparisons to -1 in the depMsgs code.
This hack here is illegal in c++. Just strdup() the silly little string, it's not like this is a performance critical spot.
This really belongs to a separate function in the first place, and doing so allows us to turn 'b' into a const char *, which in turn makes the assignment to string literal "" in the url2path case legitimate. Fun times and no functional changes.
Forward declarations to structs like we have in rpmio isn't legitimate C++, as a minimal bandaid solution declare them as extern in the internal header, and limit visibility.
Otherwise we'd need casts for each of these accesses, having a function allows doing more if necessary.
Cleaner than void pointer and avoid casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another batch of delightful trivia to appease c++.