Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --patches and --sources aliases to rpmspec #3011

Closed
wants to merge 1 commit into from

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Apr 2, 2024

These are common needs and the query is not exactly obvious, so why not.

Hijack the otherwise unused poltest.spec for the sources test, it's the only multi-source spec we have. Only, it hasn't been parseable in about ten years because of the Collections: tag, so remove that...

These are common needs and the query is not exactly obvious, so why not.

Hijack the otherwise unused poltest.spec for the sources test, it's the
only multi-source spec we have. Only, it hasn't been parseable in about
ten years because of the Collections: tag, so remove that...
@pmatilai pmatilai added RFE CLI Command-line interface packaging Package building, SPEC files, etc. labels Apr 2, 2024
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since these emit the sources and patches in reverse order, could we make the aliases also reverse that so they are in the correct order?

@pmatilai
Copy link
Member Author

pmatilai commented Apr 3, 2024

The thought crossed my mind too, I'm a bit torn on this all.

Sure, reverting the order in the aliases would be safe. But, it seems like a bug that we're storing them in reverse order in the package in the first place, and something we should fix instead. But, that'd break it for the alleged existing users who are reverting it. Are there any? I really don't know, because few people even know you can query the patches like that.

The more I think about it, the less likely it seems that doing the right thing and reverting the order of sources and patches would break anything. Had people run into that order reversion, I would've probably heard of it. And this is actually the first time that even I so much as notice it 😄

@pmatilai
Copy link
Member Author

pmatilai commented Apr 3, 2024

Coming to the conclusion that it's just not worth the trouble right now. I'll revive this once we've fixed the order (filed a ticket for that)

@pmatilai pmatilai closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command-line interface packaging Package building, SPEC files, etc. RFE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants