Sqlite backend spring cleaning #2978
Merged
+51
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes callers a little saner too
Use a separate local int for sqlite-side returns.
We're only interested in SQLITE_ROW returns in here, don't bother storing the return code which lets us use rpmRC as per the real return code of the function.
Use a separate local int for sqlite-side returns. Unsurprisingly the code looks saner too as a result: the earlier calls already set rc accordingly, and rc can only be SQLITE_DONE in the case it ran through the sqlite_step() loop, in which case we better check for in that local scope.
Similar to previous: mixing up rpmRC and sqlite codes is a bad idea and makes the code confusing at best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a particularly bad case of int/enum abuse. Not so suprisingly, using separate variables for sqlite and rpm side returns makes the stuff much saner. I can kinda remember this even: "Just make it work now, I'll clean it all up later" and this is payback time.