RFE: add way to set macro for --nocheck in rpmbuild

[ignatenkobrain]

currently when I pass --nocheck to rpmbuild, it just skips running check section, but there is no way to know this from spec file. would be nice if rpm would add some bcond for this, so packagers can do things like:

%if %{with check}
BuildRequires: xxx
%endif

or, do something like

%global _without_check 1

I remember that this was requested in RHBZ, but I can't find link (usual situation for bugzillas)..

The problem which I hit that MBS can't pass any parameters to koji (and passing them to mock is complicated in current code), so workaround was to put %__spec_check_pre exit 0 in macros file which I don't like.

[voxik]

I remember people were using BuildRequires(check) until this syntax was prohibited (this might be hint for BZ query 😄)

[ignatenkobrain]

@voxik actually when I was looking into #104 I had some similar idea for having BuildRequires(prep) which are basically needed to unpack archive and run some tool to get new BuildRequires. So it might be not that bad idea.

[pmatilai]

BuildRequires(check) never did anything special, it was just a flaw in the spec parser that BuildRequires(whatever) was accepted.

[Conan-Kudo]

@pmatilai It doesn't sound like a bad idea to have BuildRequires(stage), though. That way global controls on stages would have the proper effects during rpmbuild...

[pmatilai]

Oh, I'm sure packagers would just luv yet more pesky details to fill in.

[eclipseo]

+1 so this. Please make it possible.

[torsava]

+1 this would be a great way to standardize on disabling tests!

[ffesti]

Did a PR for this on Friday. Comments on #1256 are welcome.

[socketpair]

@ffesti could you make BuildRequires(check) to work as expected ? i.e. ignore them if --nocheck was passed.

Hmmm, dnf builddep should also consider these changes. But it should have special option for that...

[kailiu42]

I'm a bit confused after reading this issue and the PR. I have a spec file that the %check stage has some specific requirement, but I would like to make that requirement only in place when I do run the %check stage (i.e. when not using the --nocheck option of rpmbuild). Is that possible, and whether this issue is related?

[jiridanek]

I remember people were using BuildRequires(check) until this syntax was prohibited (this might be hint for BZ query smile)

Found it,

• Bug 1134397 - RFE: %check-only requirements specification
• Bug 1394870 - [RFE] Support BuildRequires(check) (closed as duplicate of the previous one)

[sergiomb2]

we can use : rpmbuild --without check

[kloczek]

we can use : rpmbuild --without check

This can be added very easy by place in global macros single line modification

# Add handle --{with|without} check
%__spec_check_pre \
        %{!?with_check:echo "%%check disabled."; exit 0} \
        %{___build_pre}

Than you can place in spec file:

%bcond_with   check

to disable %check.
I'm using that hack +3 years.

Do you want this as PR? 🤔

[kloczek]

# Add handle --{with|without} check
%__spec_check_pre \
        %{!?with_check:echo "%%check disabled."; exit 0} \
        %{___build_pre}

Actually this is not all. It needs to be added default value of the %with_check. So wole solution has two additional lines.

# Add handle --{with|without} check
%with_check   1
%__spec_check_pre \
        %{!?with_check:echo "%%check disabled."; exit 0} \
        %{___build_pre}

[sergiomb2]

I prefer handle #2362 and #1929

since I don't use it but I found many people that use _without (wrongly)

https://sourcegraph.com/search?q=context:global+r:src.fedoraproject.org+file:.*%5C.spec%24+%5C%3Fwithout_&patternType=regexp&case=yes&sm=0&groupBy=repo