Dynamic spec generation depends on %setup (for no good reason) #3063
Comments
|
So this is similar to #3042 (and probably really just a more generic version of that issue). |
pmatilai
added a commit
to pmatilai/rpm
that referenced
this issue
May 10, 2024
There's no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: rpm-software-management#3063
pmatilai
added a commit
to pmatilai/rpm
that referenced
this issue
May 10, 2024
There's no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: rpm-software-management#3063
ffesti
pushed a commit
that referenced
this issue
May 13, 2024
There's no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: #3063
dmnks
pushed a commit
to dmnks/rpm
that referenced
this issue
May 17, 2024
There's no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: rpm-software-management#3063 (cherry picked from commit f3f9f2c)
dmnks
pushed a commit
that referenced
this issue
May 17, 2024
There's no reason %specpartsdir should be dependent on %setup use, just create it when we create the build directory too. Update tests accordingly. The spec parse test is noteworthy, the specparts dir creation no longer shows up in spec parse output, which certainly is the way it should be: this is rpm internal infrastructure stuff and nothing to do with spec *parse*, this all only takes place during builds. Fixes: #3063 (cherry picked from commit f3f9f2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While poking around with debuginfo stuff, ran into the fact that %specpartsdir is generated from %setup, which limits its usefulness somewhat. Most real-world packages of course do have %setup but now with %builddir, there's no reason to limit specparts to those packages.
Should probably create it at the same time as %builddir itself to ensure its always there.
The text was updated successfully, but these errors were encountered: