Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set obsoletes < 5 for ELN/RHEL yet #1309

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sgallagher
Copy link
Contributor

The necessary pieces are not yet in place for RHEL 11 and this results in conflicts.

screenshot

@ppisar
Copy link
Contributor

ppisar commented Mar 13, 2024

Can you tell us what are "The necessary pieces are not yet in place for RHEL 11" so that we know when we can do the switch?

Besides your patch is not syntactically correct and all builds fail ("macro expansion did not return an integer: (%2)
"), I'd rather prefer changing it into "%[0%{?fedora} > 41 || 0%{?rhel} > 11]". We will decrease it to 10 when "the necessary pieces" are there.

@ppisar ppisar self-assigned this Mar 13, 2024
@ppisar
Copy link
Contributor

ppisar commented Mar 13, 2024

Guessing from the screenshot, it's that comps groups list "yum" as a mandatory package?

@sgallagher
Copy link
Contributor Author

Guessing from the screenshot, it's that comps groups list "yum" as a mandatory package?

I honestly don't know what the "necessary pieces" are, but since they're not there for f40, they are similarly not ready for ELN/RHEL 11. So if you want to make it > 11 that works fine for me. I'll push a revision.

There are conflicts with yum. This should be adjusted back once things
are properly addressed in Fedora.

Signed-off-by: Stephen Gallagher <[email protected]>
@sgallagher
Copy link
Contributor Author

For more context: we want DNF5 to be available in Fedora ELN because we want to switch to it for mock/Koji build purposes. We'll move to it as a replacement for DNF4 at the same time Rawhide does.

@ppisar
Copy link
Contributor

ppisar commented Mar 13, 2024

I'm unable to reproduce the error with a dnf5 nightly build. The ODCS compose mentioned in the screenshot does not contain dnf5 package. Koji build root for ELN contains dnf5 and it obsoletes yum, but installing "yum", or "yum dnf5" does not fail. If I add a repository with a group requiring "yum", installing that group also pass.

Isn't the error a feature of Anaconda?

@ppisar
Copy link
Contributor

ppisar commented Mar 13, 2024

The new patch looks good. After finishing rpm-build:fedora-rawhide-x86_64 test, I will merge it.
I guess you want it as soon as possible in Rawhide to propagate it to ELN.

@sgallagher
Copy link
Contributor Author

I'm unable to reproduce the error with a dnf5 nightly build. The ODCS compose mentioned in the screenshot does not contain dnf5 package. Koji build root for ELN contains dnf5 and it obsoletes yum, but installing "yum", or "yum dnf5" does not fail. If I add a repository with a group requiring "yum", installing that group also pass.

Isn't the error a feature of Anaconda?

It's entirely possible that there's something happening in lorax-templates-rhel as well. Probably needs more investigation. Let me look into that and let's hold off merging this for the moment.

@sgallagher sgallagher marked this pull request as draft March 13, 2024 14:45
@Conan-Kudo
Copy link
Member

Conan-Kudo commented Mar 14, 2024

I know that a bunch of things choke on the fact we're using Provides instead of subpackages. I've been tempted to break out the dnf, microdnf, and yum provides back into subpackages to deal with it... 😕

(At least I think I'm going to for openSUSE and Mageia, because this pain isn't worth it.)

@sgallagher sgallagher marked this pull request as ready for review March 15, 2024 12:27
@sgallagher
Copy link
Contributor Author

I can't find the specific reasons this is failing and we need to get containers building again for ELN. Let's merge this and do a build and we'll figure the rest out alongside Rawhide.

@ppisar ppisar added this pull request to the merge queue Mar 15, 2024
Merged via the queue into rpm-software-management:main with commit 141c1fa Mar 15, 2024
18 of 22 checks passed
@ppisar
Copy link
Contributor

ppisar commented Mar 15, 2024

Merged. I'm logging out now. I will do the Fedora build on Monady, unless somebody else does it sooner.

@ppisar
Copy link
Contributor

ppisar commented Mar 18, 2024

This change will be in dnf5-5.1.15-2.fc41 which is now building.

sgallagher added a commit to sgallagher/dnf that referenced this pull request Mar 18, 2024
jan-kolarik pushed a commit to rpm-software-management/dnf that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants