Split $releasever to $releasever_major and $releasever_minor #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @evan-goode! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-09-20 19:07:27 UTC |
Whenever the `releasever` substitution variable is set, automatically derive and set the `releasever_major` and `releasever_minor` vars by splitting `releasever` on the first ".". Companion to the DNF 5 implementation here: rpm-software-management/dnf5#800 DNF 5 issue: rpm-software-management/dnf5#710 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
evan-goode
force-pushed
the
evan-goode/releasever-major-minor
branch
from
2b9dc56
to
24085eb
Compare
evan-goode
added a commit
to evan-goode/libdnf
that referenced
this pull request
Oct 9, 2023
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it. DNF 4 PR: rpm-software-management/dnf#1989 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
evan-goode
added a commit
to evan-goode/libdnf
that referenced
this pull request
Oct 11, 2023
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it. DNF 4 PR: rpm-software-management/dnf#1989 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
evan-goode
added a commit
to evan-goode/libdnf
that referenced
this pull request
Oct 11, 2023
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it. DNF 4 PR: rpm-software-management/dnf#1989 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
Conan-Kudo
pushed a commit
to rpm-software-management/libdnf
that referenced
this pull request
Oct 11, 2023
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it. DNF 4 PR: rpm-software-management/dnf#1989 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
Conan-Kudo
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the
releaseversubstitution variable is set, automatically derive and set thereleasever_majorandreleasever_minorvars by splittingreleaseveron the first ".".Companion to the DNF 5 implementation here: rpm-software-management/dnf5#800. This implementation is kept similar to the implementation in DNF 5, including the caveat/potentially breaking change that setting a substitution variable can now raise an exception. If we don't want to raise an error, a simple solution would be simply to allow setting of
$releasever_majorand$releasever_minorand take out theReadOnlyVariableError.DNF 5 issue: rpm-software-management/dnf5#710
For https://bugzilla.redhat.com/show_bug.cgi?id=1789346, but merging this does not close the bug yet; the shell-style variable expansion still needs to be implemented.