Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lists of KVP in kwargs when calling add_new_repo #1962

Merged
merged 2 commits into from Jul 11, 2023

Conversation

anish
Copy link
Contributor

@anish anish commented Jul 10, 2023

The loop in substitute() returns when substitutions is non-empty. When parsing over a list, this condition is met on the first member of the list and the rest of the list is not parsed and thrown away. This can be easily reproduced by using a repo that uses more than one gpgkey :

    base.repos.add_new_repo('foo_repo', conf,
        baseurl=['https://foo/bar'],
        gpgkey=['https://foo/bar/key1','https://foo/bar/key2'],
        gpgcheck=True)

At the end of of add_new_repo, the new repo will only contain one key and not a list like this code expects

@anish anish changed the title Support lists Support lists of KVP in kwards when calling add_new_repo Jul 10, 2023
@anish anish changed the title Support lists of KVP in kwards when calling add_new_repo Support lists of KVP in kwargs when calling add_new_repo Jul 10, 2023
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha m-blaha merged commit cb654bb into rpm-software-management:master Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants