Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module_base.py #1946

Closed
wants to merge 1 commit into from
Closed

Update module_base.py #1946

wants to merge 1 commit into from

Conversation

zengwei2000
Copy link
Contributor

Check if the collection is empty to avoid errors with the NoneType attribute

@zengwei2000
Update module_base.py
7143eed 
Check if the collection is empty to avoid errors with the NoneType attribute
@evan-goode
Copy link
Member

Do you have a reproducer for a situation where install_dict could have value None for some key? It seems like the only place install_dict is written to is that line with setdefault, so it should never contain a value that is not a set.

@evan-goode evan-goode self-requested a review June 26, 2023 16:22
@evan-goode evan-goode self-assigned this Jun 26, 2023
@zengwei2000 zengwei2000 closed this by deleting the head repository Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-goode evan-goode Awaiting requested review from evan-goode

Assignees

@evan-goode evan-goode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zengwei2000 @evan-goode