dnf-data: depend on /etc/dnf/dnf.conf, not libdnf5 #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it resilient in some corner cases, such as if the user has installed an old version of libdnf5 that doesn't provide /etc/dnf/dnf.conf.
|
LGTM |
j-mracek
approved these changes
Jun 2, 2023
|
Related issue: rpm-software-management/dnf5#417. |
kontura
added a commit
to kontura/ci-dnf-stack
that referenced
this pull request
Jun 6, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rahide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
kontura
added a commit
to kontura/ci-dnf-stack
that referenced
this pull request
Jun 6, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rahide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
jan-kolarik
pushed a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Jun 6, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rahide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Jun 7, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rahide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Jun 7, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rawhide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
jan-kolarik
pushed a commit
to rpm-software-management/dnf5
that referenced
this pull request
Jun 7, 2023
This is needed because since rpm-software-management/dnf#1937 new dnf-data (in dnf-nightly) requires `/etc/dnf/dnf.conf` but in rawhide and dnf-nightly nothing provides that. It is provided by new libdnf5 currently only present in dnf5-unstable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it resilient in some corner cases, such as if the user has installed an old version of libdnf5 that doesn't provide /etc/dnf/dnf.conf.