Fix getting installed groups for given environment

The CompsEnvironmentGroup.getInstalled does not reflect which groups
are actually installed, but rather which were installed when the
environment was installed. This can cause the subsequent group
upgrade to fail.

This patch changes it so that only installed groups are upgraded.

= changelog =
related: https://bugzilla.redhat.com/show_bug.cgi?id=1872586

Closes: #1658
Approved by: j-mracek

dnf/comps.py

@@ -640,7 +640,7 @@ def _environment_upgrade(self, env_id):
  if not comps_env:
  raise CompsError(_("Environment '%s' is not available.") % env_id)
 
- old_set = set([i.getGroupId() for i in swdb_env.getGroups() if i.getInstalled()])
+ old_set = set([i.getGroupId() for i in swdb_env.getGroups()])
  pkg_types = swdb_env.getPackageTypes()
 
  # create a new record for current transaction
@@ -649,8 +649,9 @@ def _environment_upgrade(self, env_id):
  trans = TransactionBunch()
  for comps_group in comps_env.mandatory_groups:
  if comps_group.id in old_set:
- # upgrade existing group
- trans += self._group_upgrade(comps_group.id)
+ if self.history.group.get(comps_group.id):
+ # upgrade installed group
+ trans += self._group_upgrade(comps_group.id)
  else:
  # install new group
  trans += self._group_install(comps_group.id, pkg_types)