Add detection for ostree-based systems and warn users about losing ch…

…anges

On ostree-based systems, users can use dnf to customize the
environment but those changes will be lost at the next ostree-based
image update.  If you want to retain changes between ostree-updates
you need to make use of rpm-ostree right now.

Signed-off-by: David Cantrell <[email protected]>

dnf/cli/commands/__init__.py

@@ -277,6 +277,7 @@ def configure(self):
  _checkEnabledRepo(self.base)
 
  def run(self):
+ dnf.util.is_container()
  self.cli._populate_update_security_filter(self.opts, cmp_type="gte")
 
  found = self.base.check_updates(self.opts.packages, print_=True,
@@ -303,6 +304,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  found = self.base.check_updates(self.opts.pkg_specs,
  self.reponame, print_=True)
  if found:
@@ -345,6 +347,7 @@ def configure(self):
  demands.root_user = True
 
  def run_on_repo(self):
+ dnf.util.is_container()
  self.cli._populate_update_security_filter(self.opts)
  """Execute the command with respect to given arguments *cli_args*."""
  _checkGPGKey(self.base, self.cli)
@@ -398,6 +401,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
 
  done = False
@@ -453,6 +457,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
 
  done = False
@@ -516,6 +521,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
  for command in self.wrapped_commands:
  try:
@@ -562,6 +568,7 @@ def _replace(self, pkg_spec, reponame):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
 
  done = False
@@ -603,6 +610,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
 
  done = False
@@ -653,7 +661,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
-
+ dnf.util.is_container()
  done = False
 
  if not self.opts.pkg_specs:
@@ -692,6 +700,7 @@ def configure(self):
 
  def run_on_repo(self):
  """Execute the command with respect to given arguments *cli_args*."""
+ dnf.util.is_container()
  _checkGPGKey(self.base, self.cli)
 
  done = False

dnf/cli/commands/alias.py

@@ -30,6 +30,7 @@
 from dnf.cli import commands
 import dnf.conf
 import dnf.exceptions
+import dnf.util
 from dnf.i18n import _
 
 logger = logging.getLogger('dnf')
@@ -157,6 +158,8 @@ def list_alias(self, cmd):
  print(_("Alias %s='%s'") % (cmd, " ".join(args)))
 
  def run(self):
+ dnf.util.is_container()
+
  if not self.aliases_base.enabled:
  logger.warning(_("Aliases resolving is disabled."))
 

dnf/cli/commands/autoremove.py

@@ -25,6 +25,7 @@
 from dnf.i18n import _
 
 import dnf.exceptions
+import dnf.util
 import hawkey
 import logging
 
@@ -64,6 +65,8 @@ def configure(self):
  demands.fresh_metadata = False
 
  def run(self):
+ dnf.util.is_container()
+
  if any([self.opts.grp_specs, self.opts.pkg_specs, self.opts.filenames]):
  forms = []
  if self.opts.command in self.nevra_forms:

dnf/cli/commands/distrosync.py

@@ -21,6 +21,7 @@
 from __future__ import absolute_import
 from dnf.cli import commands
 from dnf.i18n import _
+import dnf.util
 
 
 class DistroSyncCommand(commands.Command):
@@ -45,4 +46,5 @@ def configure(self):
  commands._checkEnabledRepo(self.base, self.opts.package)
 
  def run(self):
+ dnf.util.is_container()
  return self.base.distro_sync_userlist(self.opts.package)

dnf/cli/commands/downgrade.py

@@ -23,6 +23,7 @@
 from dnf.cli import commands
 from dnf.cli.option_parser import OptionParser
 from dnf.i18n import _
+import dnf.util
 
 
 class DowngradeCommand(commands.Command):
@@ -50,6 +51,7 @@ def configure(self):
  commands._checkEnabledRepo(self.base)
 
  def run(self):
+ dnf.util.is_container()
  file_pkgs = self.base.add_remote_rpms(self.opts.filenames, strict=False,
  progress=self.base.output.progress)
  return self.base.downgradePkgs(

dnf/cli/commands/group.py

@@ -365,6 +365,7 @@ def configure(self):
  commands._checkGPGKey(self.base, self.cli)
 
  def run(self):
+ dnf.util.is_container()
  cmd = self.opts.subcmd
  extcmds = self.opts.args
 

dnf/cli/commands/history.py

@@ -331,6 +331,7 @@ def str2transaction_id(s):
  return sorted(tids, reverse=True), merged_tids
 
  def run(self):
+ dnf.util.is_container()
  vcmd = self.opts.transactions_action
 
  if vcmd == 'replay':

dnf/cli/commands/install.py

@@ -72,6 +72,8 @@ def configure(self):
  commands._checkEnabledRepo(self.base)
 
  def run(self):
+ dnf.util.is_container()
+
  err_pkgs = []
  errs = []
  error_module_specs = []

dnf/cli/commands/makecache.py

@@ -44,6 +44,7 @@ def set_argparser(parser):
  metavar='timer', help=argparse.SUPPRESS)
 
  def run(self):
+ dnf.util.is_container()
  timer = self.opts.timer is not None or self.opts.timer_opt
  msg = _("Making cache files for all metadata files.")
  logger.debug(msg)

dnf/cli/commands/mark.py

@@ -27,6 +27,7 @@
 from dnf.cli import commands
 
 import dnf
+import dnf.util
 import functools
 import logging
 
@@ -67,6 +68,7 @@ def configure(self):
  demands.resolving = False
 
  def run(self):
+ dnf.util.container()
  cmd = self.opts.mark[0]
  pkgs = self.opts.package
 

dnf/cli/commands/module.py

@@ -398,6 +398,7 @@ def configure(self):
  self.subcmd.configure()
 
  def run(self):
+ dnf.util.is_container()
  self.check_required_argument()
  self.subcmd.run_on_module()
 

dnf/cli/commands/reinstall.py

@@ -25,6 +25,7 @@
 from dnf.i18n import _
 
 import dnf.exceptions
+import dnf.util
 import logging
 
 logger = logging.getLogger('dnf')
@@ -59,6 +60,7 @@ def configure(self):
  commands._checkEnabledRepo(self.base)
 
  def run(self):
+ dnf.util.is_container()
 
  # Reinstall files.
  done = False

dnf/cli/commands/shell.py

@@ -83,6 +83,8 @@ def configure(self):
  setattr(self.cli.demands, attr, getattr(default_demands, attr))
 
  def run(self):
+ dnf.util.is_container()
+
  if self.opts.script:
  self._run_script(self.opts.script)
  else:

dnf/cli/commands/swap.py

@@ -58,6 +58,7 @@ def _perform(self, cmd_str, spec):
  cmd.run()
 
  def run(self):
+ dnf.util.is_container()
  # The install part must be performed before the remove one because it can
  # operate on local rpm files. Command line packages cannot be added
  # to the sack once the goal is created.

dnf/cli/commands/upgrade.py

@@ -69,6 +69,7 @@ def configure(self):
  self.skipped_grp_specs = None
 
  def run(self):
+ dnf.util.is_container()
  cmp_type = "eq" if self.upgrade_minimal else "gte"
  self.cli._populate_update_security_filter(self.opts, cmp_type=cmp_type,
  all=self.all_security)

dnf/util.py

@@ -33,11 +33,13 @@
 import functools
 import hawkey
 import itertools
+import json
 import locale
 import logging
 import os
 import pwd
 import shutil
+import subprocess
 import sys
 import tempfile
 import time
@@ -639,3 +641,43 @@ def _is_file_pattern_present(specs):
  if subj._filename_pattern:
  return True
  return False
+
+
+def is_container(msg=True):
+ """Returns true is the system is managed as an immutable container,
+ false otherwise. If msg is True, a warning message is displayed
+ for the user.
+ """
+
+ bootc = '/usr/bin/bootc'
+ _ostree_msg = _("""
+*** This system is managed with ostree. Changes to the system
+*** made with dnf will be lost with the next ostree-based update.
+*** If you do not want to lose these changes, use 'rpm-ostree'.
+""")
+
+ if not os.path.isfile(bootc) and not os.access(bootc, os.X_OK):
+ # lack of bootc command -or- inability to execute it means we're
+ # probably not a container
+ return False
+
+ p = subprocess.Popen([bootc, "status", "--json"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+ (out, err) = p.communicate()
+
+ if p.returncode != 0:
+ return False
+
+ # check the output of 'bootc status'
+ j = json.loads(out)
+
+ # XXX: the API from bootc status is evolving
+ status = j.get("status", "")
+ kind = j.get("kind", "")
+
+ if kind.lower() == "bootchost" and bool(status.get("isContainer", None)):
+ if msg:
+ logger.info(_ostree_msg)
+
+ return True
+
+ return False