Add extended test for installonly packages #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
force-pushed
the
reason-installonly-extended
branch
from
8383a5d
to
93098a3
Compare
m-blaha
reviewed
Mar 12, 2024
Comment on lines
265
to
281
| When I execute dnf with args "install abcde" | ||
| Then the exit code is 0 | ||
| And Transaction is following | ||
| | Action | Package | | ||
| | install | abcde-0:2.9.2-1.fc29.noarch | | ||
| | install-dep | wget-0:1.19.5-5.fc29.x86_64 | | ||
| | install-weak | flac-0:1.3.2-8.fc29.x86_64 | | ||
| When I execute dnf with args "mark remove abcde" | ||
| Then the exit code is 0 | ||
| And package reasons are | ||
| | Package | Reason | | ||
| | abcde-2.9.2-1.fc29.noarch | dependency | | ||
| | flac-1.3.2-8.fc29.x86_64 | weak-dependency | | ||
| | wget-1.19.5-5.fc29.x86_64 | dependency | |
There was a problem hiding this comment.
For the sake of future maintainers, I'd like to include a comment here explaining why the abcde package is needed on the system, with a dependency reason. I'm concerned that without it, anyone attempting to understand the test in a year or two might become confused.
What do you think?
There was a problem hiding this comment.
I have created a comment.
j-mracek
force-pushed
the
reason-installonly-extended
branch
from
93098a3
to
be0f39f
Compare
m-blaha
reviewed
Mar 12, 2024
| | install-dep | wget-0:1.19.5-5.fc29.x86_64 | | ||
| | install-weak | flac-0:1.3.2-8.fc29.x86_64 | | ||
| # We need to have a different packages then kernel installed and with a different reasons then user to ensure that | ||
| # reason is inherited from expected package to expected package. The package abcd or its dependencies must be |
There was a problem hiding this comment.
This is sentence is a bit confusing.
Suggested change
| # reason is inherited from expected package to expected package. The package abcd or its dependencies must be | |
| # the "kernel" package reason is unexpectedly inherited from "abcde" package. The package abcd or its dependencies must be |
There was a problem hiding this comment.
Perfect, PR was updated.
The original test is ok, but this test is for a random behavior of the code, therefore it uses more additional packages in test to triger random behavior. Required for: https://issues.redhat.com/browse/RHEL-15902
j-mracek
force-pushed
the
reason-installonly-extended
branch
from
be0f39f
to
23bea57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original test is ok, but this test is for a random behavior of the code, therefore it uses more additional packages in test to triger random behavior.
Required for: https://issues.redhat.com/browse/RHEL-15902