Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder image file field #1112

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

saravanan-inc
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 8, 2023

Someone is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 7:24AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rowy-typedoc ⬜️ Ignored (Inspect) Feb 22, 2023 at 7:24AM (UTC)

@shamsmosowi shamsmosowi self-requested a review February 17, 2023 06:15
Copy link
Member

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saravanan-inc thank you for the contribution,this looks great!
two things to improve on would be:

  • add support for reordering in the sidedrawer
  • hide the drag and drop icon when there's only one image in the cell, to save on space

@saravanan-inc
Copy link
Contributor Author

Hi @shamsmosowi thanks for updating on this issue and the bug,

Added support for reordering the both the image and file fields in the SideDrawer
Add hide the image and file fields drag option if there is only one file or one image

@shamsmosowi
Copy link
Member

Hi @shamsmosowi thanks for updating on this issue and the bug,

Added support for reordering the both the image and file fields in the SideDrawer Add hide the image and file fields drag option if there is only one file or one image

Perfect! Thank you @saravanan-inc !

@shamsmosowi shamsmosowi merged commit eee88d9 into rowyio:develop Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants