-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid bar being cut at edges #625
Comments
How many icons you have, on which device? I was able to fit 8 items / tabs without any clipping on a Nexus S portrait screen, so I'm not sure how to replicate your problem. |
If you have some sample code that could replicate your issue, that would help a lot. |
Must be related to a recent change that changed the tab width calculation reference from screen width to the BottomBar width. Still can't replicate since I don't have Huawei G8. There must be some device-specific quirk there. I modified the logic just now to have the reference width to be at most the screen width. Could you test with the newest source for the sample if that fixed it? |
Now it's working perfect! I tried with another device; Samsung Core Prime with Android 5.1.1 and I had the same issue, but as I said now it's working good on both devices. |
Nice! Glad I could help. This really isn't the norm by the way, I just had a good hunch! |
I made a completely new release just for this, since it's a pretty major issue for affected devices. Thanks for reporting this! |
Had the same problem with my old phone |
* upstream/master: (43 commits) Made a new release for fixing a major bug (roughike#625) that could affect some devices. Attempt to fix roughike#625 by allowing the reference width for tab calculations to be at most the screen width. Added a latest version badge, since all other cool kids do it Updated README for dependencies for the new version. Removed the debugging code. Attempt to fix failing Travis build. Made some previously private BottomBarTab methods public. Made some previously private BottomBarTab methods public. Updated changelog to include a mention of fixing roughike#591. Got rid of the refreshTabs method thus fixing a major flaw that caused all other properties to reset. Updated tools and support libraries. Update README.md Merged and added tests for roughike#585. Updated changelog. Merged roughike#457 with small modifications Fixed accidental setting of items twice when inflating from XML. Updated changelog. Wrote a test for verifying correct behavior when setting new items programmatically. Attempt to fix failing Travis builds. Merged roughike#504 with some optimizations to the tab resizing logic. ... # Conflicts: # bottom-bar/src/main/java/com/roughike/bottombar/BottomBarBadge.java # bottom-bar/src/main/java/com/roughike/bottombar/BottomBarTab.java
Hi, I would like to avoid the bottombar to be cut at the left and right edges. I mean to keep every icon completely inside of the screen.
Is it possible? How can be done?
Thanks in advance and sorry for my english.
The text was updated successfully, but these errors were encountered: