feat(tools): location_mappings support for packageddb #8141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `main.py` script now fetches the latest location asset mappings and applies them using the `RotkiDataUpdater`.
moxw
force-pushed
the
location-mappings-consistency
branch
from
d3917a1
to
687ec8b
Compare
moxw
added
the
ready for peer review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8141 +/- ##
===========================================
- Coverage 80.41% 80.36% -0.05%
===========================================
Files 1225 1245 +20
Lines 107856 109070 +1214
Branches 13130 13323 +193
===========================================
+ Hits 86731 87659 +928
- Misses 18812 19031 +219
- Partials 2313 2380 +67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yabirgb
reviewed
Jun 25, 2024
Comment on lines
+117
to
+122
| for version in range(1, latest_version + 1): | ||
| data_url = DATA_UPDATES_URL.format(branch='develop', data=key, version=latest_version) | ||
| data_file = query_file(url=data_url, is_json=True) | ||
| updates[version] = { | ||
| UpdateType.LOCATION_ASSET_MAPPINGS: data_file, | ||
| } |
There was a problem hiding this comment.
You are re-inventing the wheel here. We already have this logic in the app. Here is an example of how to implement it https://github.com/rotki/rotki/pull/7827/files#diff-36b9d1f1d98f8ba05186a958ba992ba8f6a6d8d82f4f9597578bc8b946f31f23R27
Comment on lines
+176
to
+185
| infojson = get_remote_info_json() | ||
| updates = _retrieve_data_files( | ||
| infojson=infojson, | ||
| ) | ||
| for version, _updates in updates.items(): | ||
| updated_data = _updates.get(UpdateType.LOCATION_ASSET_MAPPINGS) | ||
| if updated_data is None: | ||
| print('Remote update invalid') | ||
| continue # perhaps broken file? Skipping | ||
| RotkiDataUpdater.update_location_asset_mappings(updated_data, version) |
Comment on lines
+127
to
+130
| def get_remote_info_json() -> dict[str, Any]: | ||
| """Retrieve remote file with information for different updates | ||
|
|
||
| May raise RemoteError if anything is wrong contacting github |
|
|
||
| add_logging_level('TRACE', TRACE) | ||
| DATA_UPDATES_URL = 'https://raw.githubusercontent.com/rotki/data/{branch}/updates/{data}/v{version}.json' |
There was a problem hiding this comment.
you don't need to re-difine it. We already have it in update_single
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
main.pyscript now fetches the latest location asset mappings and applies them using theRotkiDataUpdater.