Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): show total collateralization ratio for liquity trove #8138

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@lukicenturi lukicenturi force-pushed the adjust-liquity branch 2 times, most recently from c8349fa to a88f3ee Compare June 21, 2024 16:24
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 36 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (7411881) to head (c6c718b).
Report is 16 commits behind head on develop.

Files Patch % Lines
...ents/defi/loan/loans/liquity/LiquityCollateral.vue 0.00% 29 Missing ⚠️
frontend/app/src/components/defi/loan/LoanRow.vue 0.00% 3 Missing ⚠️
frontend/app/src/composables/defi/lending.ts 0.00% 3 Missing ⚠️
frontend/app/src/store/defi/liquity/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8138       +/-   ##
============================================
- Coverage    80.36%   53.78%   -26.59%     
============================================
  Files         1248     1701      +453     
  Lines       109320   167899    +58579     
  Branches     13360    13859      +499     
============================================
+ Hits         87859    90305     +2446     
- Misses       19068    75204    +56136     
+ Partials      2393     2390        -3     
Flag Coverage Δ
frontend_integration 59.74% <50.00%> (+0.24%) ⬆️
frontend_unit 38.88% <9.75%> (-40.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks :)

@kelsos kelsos merged commit 7109d77 into rotki:develop Jun 24, 2024
15 checks passed
@kelsos kelsos deleted the adjust-liquity branch June 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants