-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(htx): implement deposit, withdrawal, and trade queries #8135
Conversation
989f7ca
to
231dd71
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8135 +/- ##
===========================================
- Coverage 80.41% 71.04% -9.37%
===========================================
Files 1225 1248 +23
Lines 107881 109320 +1439
Branches 13129 13360 +231
===========================================
- Hits 86750 77665 -9085
- Misses 18817 29658 +10841
+ Partials 2314 1997 -317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the last PR? if so add the changelog entry
7c58de9
to
30e89d9
Compare
30e89d9
to
8405843
Compare
8405843
to
676cad1
Compare
30a9b82
to
b5baabc
Compare
Querying the trades with the API key that we have I got:
|
4b0957b
to
5774656
Compare
5e7051a
to
04f12cf
Compare
04f12cf
to
cb48580
Compare
cb48580
to
15c41d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still things not addressed from last PR review...
15c41d8
to
3774405
Compare
3774405
to
7411881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as what I asked is there.
One TODO that comes out of it is what I wrote in discord:
But you can do better and also check that the request to the CEX matches what you
expect. So test the request part too. Cause right now the app can send a ping to the > CEX and the test would happily pass.
Please fix this in another PR. If this is green.
Closes #2323