Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: day names was wrong on the calendar page #8090

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Jun 14, 2024

Closes #8088

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.62%. Comparing base (06ef2d3) to head (681c0ce).
Report is 6 commits behind head on develop.

Files Patch % Lines
...d/app/src/components/calendar/CalendarWeekdays.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #8090       +/-   ##
============================================
- Coverage    80.41%   53.62%   -26.80%     
============================================
  Files         1226     1679      +453     
  Lines       108215   166723    +58508     
  Branches     13173    13683      +510     
============================================
+ Hits         87021    89405     +2384     
- Misses       18868    74992    +56124     
  Partials      2326     2326               
Flag Coverage Δ
frontend_integration 59.44% <0.00%> (-0.04%) ⬇️
frontend_unit 38.79% <91.30%> (-40.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi marked this pull request as draft June 14, 2024 12:47
@lukicenturi lukicenturi marked this pull request as ready for review June 14, 2024 14:01
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukicenturi lukicenturi merged commit 4b582fa into rotki:develop Jun 14, 2024
15 checks passed
@lukicenturi lukicenturi deleted the fix-calendar-wrong-days branch June 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date names in the calendar
2 participants