Support Coinbase staking_reward tx type #7619
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7619 +/- ##
===========================================
+ Coverage 53.72% 53.74% +0.02%
===========================================
Files 1706 1706
Lines 168410 168498 +88
Branches 13901 13914 +13
===========================================
+ Hits 90478 90564 +86
- Misses 75512 75517 +5
+ Partials 2420 2417 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Left a comment about the change.
For the subtype, would need to check.
I think the interest/inflation_reward/staking_rewards can be like this.
But if you see the place you edited has another elif which is afaics (but I am not sure since I don't use coinbase and did not write the code) concerns internal movements/receivals. So that part should stay as is.
| @@ -538,7 +538,7 @@ def _query_single_account_transactions( | |||
| elif tx_type in ('buy', 'sell'): | |||
| self._process_normal_trade(event=transaction, trades=trades) | |||
| elif ( | |||
| tx_type in ('interest', 'inflation_reward') or | |||
There was a problem hiding this comment.
If this exists as a transaction type then it's a good addition.
Can you also edit the test at test_coinbase_query_income_loss_expense and add a mock event with this type and test it in the test?
There was a problem hiding this comment.
Done. This is how I get the data from the API, unfortunately without any notes
coinyon
force-pushed
the
coinbase-staking-rewards
branch
from
305fc5b
to
4a32282
Compare
coinyon
force-pushed
the
coinbase-staking-rewards
branch
from
4a32282
to
56065fc
Compare
|
@LefterisJP The test failures seem unrelated |
When digging into coinbase API responses, I found that rotki ignored the
staking_rewardtx type. This PR adds support in the same way asinflation_rewardandinterest.As a related note, I don't know why all three (
interest,inflation_rewardandstaking_reward) are reported with Event Subtype NONE where they could be reported as REWARD. If you want me to change this as well with this PR, let me know.Checklist