Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing issue #18 and fixing not raising exception on running API #23

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

spookyahell
Copy link
Contributor

No description provided.

@spookyahell spookyahell changed the title Closing ( Closing issue #18 Aug 4, 2021
@spookyahell spookyahell changed the title Closing issue #18 Closing issue #18 and fixing not raising exception on running API Aug 4, 2021
@rosineygp
Copy link
Owner

there is some small erros, but I will try to fix here..

nice feature, thanks!!!!

@rosineygp
Copy link
Owner

@spookyahell
Copy link
Contributor Author

spookyahell commented Aug 4, 2021

https://github.com/rosineygp/PyIsEven/actions/runs/1099432163

regarding 2.7 btw.. probably time to start dropping support for it...
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021.

(closes rosineygp#18)
See pull request for a screenshot of how many tries it really took to pass all tests
@spookyahell
Copy link
Contributor Author

spookyahell commented Aug 4, 2021


Took a (bit more than a) full hour, but now all issues are resolved.

This can be reviewed here: https://github.com/spookyahell/PyIsEven/actions/runs/1099593446

@rosineygp rosineygp mentioned this pull request Aug 6, 2021
@rosineygp rosineygp merged commit c947734 into rosineygp:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants