Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromRawInput method #446

Closed
wants to merge 4 commits into from
Closed

Add FromRawInput method #446

wants to merge 4 commits into from

Conversation

pedoc
Copy link

@pedoc pedoc commented May 19, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.42 🎉

Comparison is base (7ebf948) 74.22% compared to head (eed9462) 74.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   74.22%   74.65%   +0.42%     
==========================================
  Files         111      112       +1     
  Lines        2778     2825      +47     
==========================================
+ Hits         2062     2109      +47     
  Misses        716      716              
Impacted Files Coverage Δ
FFMpegCore/FFMpeg/FFMpegArguments.cs 79.36% <0.00%> (-1.29%) ⬇️
FFMpegCore/FFMpeg/FFMpeg.cs 67.17% <72.72%> (+0.32%) ⬆️
FFMpegCore/FFMpeg/Arguments/GifPaletteArgument.cs 100.00% <100.00%> (ø)
FFMpegCore/FFMpeg/Enums/FileExtension.cs 38.88% <100.00%> (+3.59%) ⬆️
FFMpegCore/FFMpeg/FFMpegArgumentOptions.cs 85.00% <100.00%> (+0.25%) ⬆️
FFMpegCore/FFMpeg/FFMpegArgumentProcessor.cs 88.37% <100.00%> (ø)
FFMpegCore/FFMpeg/SnapshotArgumentBuilder.cs 80.39% <100.00%> (+26.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pedoc added 3 commits May 19, 2023 15:25
This warning will be triggered when restoring nuget package from http source, but https is completely unnecessary in private network, so this warning should be ignored.

details
https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1803
@rosenbjerg
Copy link
Owner

I don't see how FromRawInput is different from FromFileInput, besides always passing false to verifyExists

@pedoc
Copy link
Author

pedoc commented Sep 26, 2023

yes,you are right. 😄

@pedoc pedoc closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants